Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I fix a bug that's present in the action currently:
In Ruby, an empty string is truthy. As a result, passed a value of
""
or"nil"
, these branches of the code will run. As a result, we need to change the default values of the input to""
and check if the passed value is an empty string. No parsing is done to the values passed in as args so these are just strings."nil"
doesn't becomenil
and is truthy.In
irb
, you can check the following:In addition, I do some other clean up - make the option descriptions more consistent and restore an optimization that was recently removed.